[Backport] Fixes for pipeline extension request handling (#10031) #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the way that we handle bad input specs and empty requirements files. Before, an empty requirements file would cause the pipeline creation to fail because it was defaulting to the home directory of the container, since the requirements file was an empty string and not `None`. Now, it correctly defaults to no requirements file. Bad input specs before would throw 500 responses, which is incorrect given it is due to user error. [INT-1261](https://pachyderm.atlassian.net/browse/INT-1266) [INT-1261]: https://pachyderm.atlassian.net/browse/INT-1261?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Kevin Yang <kevin.yang@hpe.com>
kevyang
requested review from
a team and
bbonenfant
and removed request for
a team
bbonenfant
approved these changes
May 10, 2024
| @@ -81,6 +81,8 @@ def from_notebook(cls, notebook_path: Union[str, Path]) -> "PpsConfig": | |||
| if input_spec_str is None: | |||
| raise ValueError("field input_spec not set") | |||
| input_spec_dict = yaml.safe_load(input_spec_str) | |||
| if input_spec_dict is None: | |||
There was a problem hiding this comment.
I just did a little testing and it looks like yaml.safe_load only returns None if the input string is empty or only whitespace. Were you able to get find any other ways to result in None? If not maybe the error message should say that the value is not set?
There was a problem hiding this comment.
You may be right here, I found this when I accidentally submitted a pipeline request without the input spec. Since this is a backport, I can update this message in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the way that we handle bad input specs and empty requirements files. Before, an empty requirements file would cause the pipeline creation to fail because it was defaulting to the home directory of the container, since the requirements file was an empty string and not
None. Now, it correctly defaults to no requirements file. Bad input specs before would throw 500 responses, which is incorrect given it is due to user error.INT-1261