Add configurable limits for the worker sidecar in PPS pipeline specs #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Something went wrong the preview failed! 🙁 Check the deployment logs for errors! Built with commit 584d135 https://app.netlify.com/sites/pachyderm-docs/deploys/5ee7f35c6fe4fc00071511cf |
svekars
added
the
needs docs
msteffen
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes deployments may automatically apply limits to containers, but these limits may not be informed by the requests that we specify for our containers for PPS pipelines. This may result in impossible-to-satisfy situations where we request more than the default-applied limit. Before this PR, there was no way to specify limits for the init or sidecar (aka
storage) containers.This PR adds a way to configure the limits of the worker sidecar explicitly, as well as defaulting the init container to use the limits of the
usercontainer, the same as it already does for resource requests.I named the new field
SidecarResourceLimitsbut another option may beStorageResourceLimits. I felt that would be confusing, as it's ambiguous if we're referencing object storage rather than thestoragecontainer. Feel free to suggest a new name for the field.This is intended to be merged into
1.10.xas well asmasterfor 1.11. A future PR may add default limits for 1.11, but there may be some open questions there. This fixes #4907.