Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debug API compatible with auth (1.11.x) #5473

Merged
merged 1 commit into from Nov 30, 2020

Conversation

brycemcanally
Copy link
Contributor

1.11.x PR for #5471

Copy link
Contributor

@msteffen msteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FWIW, I typically don't seek approval for 1.11.x PRs if they're identical (i.e. a rebase) of changes that were already reviewed and approved in the master branch. Maybe that's a mistake, though my understanding is that this is Pachyderm's recommended practice.

Is this branch different from the master version? I didn't notice the differences if so.

@brycemcanally
Copy link
Contributor Author

I think it would be a good idea to seek a review / approval for all PRs that will be going into a release branch. Even if the change is identical to a change on master, it would be good to have a sanity check to make sure it is indeed identical (and that it should be identical in the release branch). @jdoliner and / or @nitinjainsj should probably decide on this, but my opinion is that a review / approval should be required for anything that is going into a release.

@brycemcanally brycemcanally merged commit dbe1e7e into 1.11.x Nov 30, 2020
@brycemcanally brycemcanally deleted the debug-dump-auth-1.11.x branch November 30, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants