Unset Worker SecurityContexts when pachd.securityContext.enabled=false #7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false when helm's pachd.securityContext.enabled=false
acohen4
force-pushed
the
acohen4/disable-worker-sec-ctx
branch
from
e03d9f9
to
8b41eaf
Compare
chainlink
reviewed
Jan 5, 2022
| @@ -152,6 +152,10 @@ spec: | |||
| - name: NO_PROXY | |||
| value: {{.Values.global.noProxy}} | |||
| {{ end }} | |||
| {{- if not .Values.pachd.securityContext.enabled }} | |||
There was a problem hiding this comment.
This feels a little weird, I think we should be pulling using the .enabled value as the value of the env var itself
acohen4
added a commit
that referenced
this pull request
Jan 5, 2022
#7218) Exposing pachd env-var ENABLE_WORKER_SECURITY_CONTEXTS that is set to false when helm's pachd.securityContext.enabled=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.