New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INT-674] Spark compatibility in the S3 gateway #8115
Conversation
cherry-pick 3651a2a; fix merge conflicts
…icting directories & files, such as in an open commit being written to by Spark.
Codecov Report
@@ Coverage Diff @@
## 2.3.x #8115 +/- ##
==========================================
- Coverage 22.24% 22.23% -0.01%
==========================================
Files 415 415
Lines 112184 112189 +5
==========================================
- Hits 24955 24949 -6
- Misses 82940 82942 +2
- Partials 4289 4298 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM! Just a couple comments about not losing err values in debug message. My comments about the ListFile vs InspectFile is mainly for my own understanding.
Also, is the plan to merge this into master later? |
I'll make a PR into master now. |
… into luke-spark-s3g-fresh
Here's the master PR: #8129 |
These are the changes needed to the S3 Gateway to make it work with Spark, and an example of how to use it.
InspectFile
doesn't work correctly in this case, butListFile[0]
works just fine.This is important for a customer, so it would be great if we could get it into 2.3.2 please :-)
Master PR - #8129