add build-docker-image dependency for load tests #8127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molinamelendezj
changed the title
chainlink
approved these changes
Aug 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #8127 +/- ##
==========================================
- Coverage 22.63% 1.65% -20.99%
==========================================
Files 426 172 -254
Lines 113608 71993 -41615
==========================================
- Hits 25717 1188 -24529
+ Misses 83489 70705 -12784
+ Partials 4402 100 -4302
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
molinamelendezj
added a commit
that referenced
this pull request
Aug 30, 2022
* move load test to ci workflow conditionally runs * add build-docker-image dependency for load tests * keep load test step as they were
molinamelendezj
added a commit
that referenced
this pull request
Aug 30, 2022
robert-uhl
pushed a commit
that referenced
this pull request
Oct 17, 2022
* move load test to ci workflow conditionally runs * add build-docker-image dependency for load tests * keep load test step as they were
robert-uhl
pushed a commit
that referenced
this pull request
Oct 17, 2022
* move load test to ci workflow conditionally runs * add build-docker-image dependency for load tests * keep load test step as they were
robert-uhl
pushed a commit
that referenced
this pull request
Oct 26, 2022
* move load test to ci workflow conditionally runs * add build-docker-image dependency for load tests * keep load test step as they were
robert-uhl
pushed a commit
that referenced
this pull request
Oct 27, 2022
* move load test to ci workflow conditionally runs * add build-docker-image dependency for load tests * keep load test step as they were
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly runs are still broken since now we are building arm64 images, and requires the binfmt_misc hack. So proposing we don't rebuild docker images in different places. and only use the same job and make nightly load depend on that.
nightly load will now use same image build job instead of rebuilding in its script. we should consider using the built in requires in circle ci and get rid of
wait_for_docker_images.shthe ci tests too