[CORE-1011] Change liveness probe to not use URI

[tybritten]

switches the liveness probe to using cli switches instead of URI. URI breaks if the username or password has an @ in it.

[jrockway]

Looks good. I always worry about spaces and weird characters in shell expansions, but I am not sure what features to help us are available in /bin/sh (versus bash). I'd test this with quotes and spaces in the password if you feel like it.

[tybritten]

Good point. We can do this for now but once we switch the pg bouncer image, we could just build a pgpassword file at start https://www.postgresql.org/docs/current/libpq-pgpass.html

[codecov]

Codecov Report

Merging #8128 (f9d3ce3) into master (51affd3) will decrease coverage by 20.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #8128       +/-   ##
==========================================
- Coverage   22.74%   2.30%   -20.45%     
==========================================
  Files         420     331       -89     
  Lines      113061   98517    -14544     
==========================================
- Hits        25717    2268    -23449     
- Misses      82971   95948    +12977     
+ Partials     4373     301     -4072     

Impacted Files	Coverage Δ
src/server/auth/db.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/watch/op.go	0.00% <0.00%> (-100.00%)	⬇️
src/server/license/db.go	0.00% <0.00%> (-100.00%)	⬇️
src/server/identity/db.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/miscutil/log.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/dbutil/option.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/miscutil/math.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/randutil/rand.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/pfsload/client.go	0.00% <0.00%> (-100.00%)	⬇️
src/internal/pfsfile/pfsfile.go	0.00% <0.00%> (-100.00%)	⬇️
... and 315 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more