[2.3.x backport] PPS: Be more careful about k8s errors during RC updates #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* promutil: also log outgoing http requests * PPS master: don't fail the pipeline because of context canceled / deadline exceeded errors * pps: side effects: add stringification of side effects * pps: pipelineController: return description of failing side effect * pps: pipeline controller: log more about scaling; prefix all messages with "PPS master" * promutil: make http logs less verbose (PPS spams the heck out of k8s while idle; we have metrics to watch those) * pps: pipeline controller: add some more information in debug logs during scale up * promutil: fix lint
acohen4
approved these changes
Oct 10, 2022
Codecov Report
@@ Coverage Diff @@
## 2.3.x #8264 +/- ##
==========================================
- Coverage 22.33% 22.25% -0.08%
==========================================
Files 415 415
Lines 112192 112262 +70
==========================================
- Hits 25059 24986 -73
- Misses 82877 82982 +105
- Partials 4256 4294 +38
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8244
promutil: also log outgoing http requests
PPS master: don't fail the pipeline because of context canceled / deadline exceeded errors
pps: side effects: add stringification of side effects
pps: pipelineController: return description of failing side effect
pps: pipeline controller: log more about scaling; prefix all messages with "PPS master"
promutil: make http logs less verbose (PPS spams the heck out of k8s while idle; we have metrics to watch those)
pps: pipeline controller: add some more information in debug logs during scale up
promutil: fix lint