Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport CORE-1123 to Pachyderm 2.3 #8283

Merged
merged 1 commit into from Oct 17, 2022
Merged

Backport CORE-1123 to Pachyderm 2.3 #8283

merged 1 commit into from Oct 17, 2022

Conversation

FahadBSyed
Copy link
Contributor

Description

This PR backports a feature to 2.3 which allows a user to configure lokiHost and lokiPort in pachyderm directly. This allows them to use a loki instance in another namespace. The existing lokiDeploy flag sets the above variables using variable substitutions to point to the pachyderm-loki service that is created by default.

* [CORE-1123] Allow users to configure pachyderm to use a loki instance in an external namespace.

* [CORE-1123] Integrate PR Feedback.
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #8283 (fb63a5d) into 2.3.x (e5cf0fe) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            2.3.x    #8283      +/-   ##
==========================================
- Coverage   22.30%   22.25%   -0.06%     
==========================================
  Files         415      415              
  Lines      112266   112266              
==========================================
- Hits        25044    24987      -57     
- Misses      82952    82981      +29     
- Partials     4270     4298      +28     
Impacted Files Coverage Δ
src/internal/serviceenv/config.go 38.09% <ø> (ø)
src/internal/serviceenv/service_env.go 55.69% <0.00%> (ø)
src/server/debug/server/server.go 4.40% <0.00%> (ø)
src/server/pps/server/worker_rc.go 0.45% <0.00%> (ø)
src/internal/storage/track/gc.go 74.41% <0.00%> (-9.31%) ⬇️
src/internal/storage/chunk/chain.go 87.09% <0.00%> (-6.46%) ⬇️
src/server/pfs/server/val_server.go 48.21% <0.00%> (-5.36%) ⬇️
src/internal/storage/fileset/compaction.go 72.34% <0.00%> (-4.26%) ⬇️
src/server/pfs/server/trigger.go 73.21% <0.00%> (-3.58%) ⬇️
src/internal/storage/chunk/uploader.go 86.20% <0.00%> (-3.45%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jrockway jrockway merged commit 278239f into 2.3.x Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants