Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport [CORE-1198] Add a timeout to loki requests from debug dump (#8329) #8331

Merged
merged 1 commit into from Oct 31, 2022

Conversation

armaanv
Copy link
Contributor

@armaanv armaanv commented Oct 31, 2022

  • loki timeout and line num change

  • move timout to debug dump server

* loki timeout and line num change

* move timout to debug dump server
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #8331 (a856def) into 2.3.x (781958d) will decrease coverage by 18.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            2.3.x   #8331       +/-   ##
==========================================
- Coverage   22.26%   3.45%   -18.81%     
==========================================
  Files         415     201      -214     
  Lines      112267   74159    -38108     
==========================================
- Hits        24995    2563    -22432     
+ Misses      82979   71236    -11743     
+ Partials     4293     360     -3933     
Impacted Files Coverage Δ
src/server/auth/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/watch/op.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/log.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/math.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/grpcutil/error.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/randutil/unique.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/testutil/naming.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/storage/fileset/metadata_store.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/storage/track/tracker.go 3.70% <0.00%> (-96.30%) ⬇️
src/internal/task/etcd_queue.go 0.00% <0.00%> (-93.55%) ⬇️
... and 363 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@armaanv armaanv merged commit 579f552 into 2.3.x Oct 31, 2022
@armaanv armaanv deleted the armaan/backport branch October 31, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants