Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration load testing (2.3.x) #8343

Merged
merged 1 commit into from Nov 4, 2022
Merged

Conversation

brycemcanally
Copy link
Contributor

2.3.x PR for #8292

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #8343 (bc45c7a) into 2.3.x (14a9c24) will decrease coverage by 0.12%.
The diff coverage is 13.69%.

@@            Coverage Diff             @@
##            2.3.x    #8343      +/-   ##
==========================================
- Coverage   22.32%   22.19%   -0.13%     
==========================================
  Files         415      416       +1     
  Lines      112269   113041     +772     
==========================================
+ Hits        25065    25093      +28     
- Misses      82944    83636     +692     
- Partials     4260     4312      +52     
Impacted Files Coverage Δ
src/internal/ppsload/pipeline.go 0.00% <0.00%> (ø)
src/pps/pps.pb.go 3.12% <0.00%> (-0.02%) ⬇️
src/internal/ppsload/ppsload.pb.go 1.25% <1.25%> (ø)
src/internal/pfsload/pfsload.pb.go 22.90% <19.32%> (-0.55%) ⬇️
src/pfs/pfs.pb.go 36.50% <28.37%> (-0.08%) ⬇️
src/internal/pfsload/commit.go 33.33% <29.16%> (-11.12%) ⬇️
src/server/pfs/cmds/cmds.go 31.35% <33.33%> (+0.07%) ⬆️
src/internal/pfsload/validator.go 65.51% <50.00%> (-1.99%) ⬇️
src/server/pfs/server/api_server.go 63.56% <57.14%> (+0.32%) ⬆️
src/server/pps/cmds/cmds.go 26.57% <66.66%> (+0.11%) ⬆️
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@FahadBSyed FahadBSyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the files to master file by file and didn't see anything conspicuous

@brycemcanally brycemcanally merged commit 14f9b25 into 2.3.x Nov 4, 2022
@brycemcanally brycemcanally deleted the migration-load-testing-2.3.x branch November 4, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants