Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4.x backport][Mount Server] Mount latest non-alias commit on branch #8366

Merged
merged 1 commit into from Nov 17, 2022
Merged

[2.4.x backport][Mount Server] Mount latest non-alias commit on branch #8366

merged 1 commit into from Nov 17, 2022

Conversation

smalyala
Copy link
Contributor

2.4.x PR for #8344. Cherry-picks changes and removes project-related rpcs

@smalyala
[Mount Server] Mount latest non-alias commit on branch (#8344)
631ea54 
* Mount latest non-alias commit on branch

* Case where mounting non-existent branch

* PR feedback
@smalyala smalyala requested a review from a team as a code owner November 15, 2022 16:28
@smalyala smalyala requested review from brycemcanally and removed request for a team and brycemcanally November 15, 2022 16:28
@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited

Codecov Report

Merging #8366 (631ea54) into 2.4.x (cb42e53) will decrease coverage by 0.05%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##            2.4.x    #8366      +/-   ##
==========================================
- Coverage   38.81%   38.76%   -0.06%     
==========================================
  Files         425      425              
  Lines      117381   117386       +5     
==========================================
- Hits        45559    45502      -57     
- Misses      62709    62742      +33     
- Partials     9113     9142      +29
Impacted Files Coverage Δ
src/server/pfs/fuse/server.go 48.19% <76.47%> (+0.46%) ⬆️
src/internal/storage/track/gc.go 74.41% <0.00%> (-9.31%) ⬇️
src/internal/storage/renew/renewer.go 91.89% <0.00%> (-8.11%) ⬇️
src/internal/dbutil/tx.go 85.71% <0.00%> (-5.72%) ⬇️
src/server/pfs/server/val_server.go 51.78% <0.00%> (-3.58%) ⬇️
src/internal/collection/postgres_collection.go 80.87% <0.00%> (-2.92%) ⬇️
src/server/pfs/server/compaction.go 70.75% <0.00%> (-2.09%) ⬇️
src/internal/storage/track/postgres_tracker.go 81.44% <0.00%> (-2.07%) ⬇️
src/server/pps/server/pipeline_state_driver.go 75.97% <0.00%> (-1.95%) ⬇️
src/internal/storage/fileset/compaction.go 79.67% <0.00%> (-1.63%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

msteffen
msteffen approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@msteffen msteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

msteffen
msteffen requested changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@msteffen msteffen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let me take another look, sorry—the set of changed files seems large

msteffen
msteffen approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@msteffen msteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looks like it was just a rebase artifact or something. Sorry for the holdup!

@smalyala smalyala merged commit e67ba47 into 2.4.x Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msteffen msteffen msteffen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smalyala @msteffen