Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFS-10] Fix Misleading Version Check Logic 2.4.x Backport #8399

Merged
merged 1 commit into from Nov 30, 2022

Conversation

FahadBSyed
Copy link
Contributor

No description provided.

@FahadBSyed FahadBSyed requested review from acohen4 and a team as code owners November 30, 2022 16:03
@FahadBSyed FahadBSyed requested review from brycemcanally and JimmyWhitaker and removed request for a team November 30, 2022 16:03
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #8399 (914b8ba) into 2.4.x (8fca5b9) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            2.4.x    #8399      +/-   ##
==========================================
- Coverage   38.81%   38.76%   -0.06%     
==========================================
  Files         425      425              
  Lines      117396   117416      +20     
==========================================
- Hits        45569    45516      -53     
- Misses      62718    62770      +52     
- Partials     9109     9130      +21     
Impacted Files Coverage Δ
src/client/admin.go 0.00% <0.00%> (ø)
src/client/client.go 26.32% <0.00%> (-0.52%) ⬇️
src/internal/minikubetestenv/deploy.go 0.00% <0.00%> (ø)
src/internal/pachd/builder.go 0.00% <ø> (ø)
src/server/admin/cmds/cmds.go 41.17% <0.00%> (ø)
src/server/pfs/server/val_server.go 50.00% <0.00%> (-5.36%) ⬇️
src/internal/transactionenv/env.go 70.13% <0.00%> (-4.17%) ⬇️
src/internal/storage/chunk/uploader.go 86.20% <0.00%> (-3.45%) ⬇️
src/internal/storage/fileset/writer.go 80.99% <0.00%> (-3.31%) ⬇️
src/internal/storage/chunk/batcher.go 85.71% <0.00%> (-3.18%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FahadBSyed FahadBSyed changed the title [PFS-10] Fix Misleading Version Check Logic [PFS-10] Fix Misleading Version Check Logic 2.4.x Backport Nov 30, 2022
@FahadBSyed FahadBSyed merged commit f029fd8 into 2.4.x Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants