Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4.x port][CORE-1231] pass pachctl args to server for audit logging #8423

Merged
merged 1 commit into from Dec 8, 2022

Conversation

armaanv
Copy link
Contributor

@armaanv armaanv commented Dec 8, 2022

backport for #8356

* send args in metadata

* log user commands
@armaanv armaanv changed the base branch from master to 2.4.x December 8, 2022 15:30
@armaanv armaanv requested review from a team as code owners December 8, 2022 15:30
@armaanv armaanv requested review from robert-uhl, FahadBSyed and lukemarsden and removed request for a team December 8, 2022 15:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
15 out of 16 committers have signed the CLA.

✅ lbliii
✅ FahadBSyed
✅ chainlink
✅ molinamelendezj
✅ seslattery
✅ jrockway
✅ robert-uhl
✅ brycemcanally
✅ brendoncarroll
✅ smalyala
✅ tybritten
✅ albscui
✅ acohen4
✅ armaanv
✅ djanicekpach
❌ nikolay-pavlov-snkeos
You have signed the CLA already but the status is still pending? Let us recheck it.

@armaanv armaanv requested review from molinamelendezj and removed request for FahadBSyed and lukemarsden December 8, 2022 15:31
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #8423 (84daafc) into 2.4.x (360e5fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            2.4.x    #8423   +/-   ##
=======================================
  Coverage   38.76%   38.77%           
=======================================
  Files         425      425           
  Lines      117416   117422    +6     
=======================================
+ Hits        45521    45535   +14     
+ Misses      62766    62758    -8     
  Partials     9129     9129           
Impacted Files Coverage Δ
src/client/client.go 26.68% <100.00%> (+0.35%) ⬆️
src/internal/middleware/logging/interceptor.go 95.13% <100.00%> (+0.07%) ⬆️
src/server/pps/server/pipeline_state_driver.go 75.97% <0.00%> (-1.95%) ⬇️
src/server/pfs/server/trigger.go 78.57% <0.00%> (-1.79%) ⬇️
src/internal/transactionenv/env.go 72.91% <0.00%> (-1.39%) ⬇️
src/internal/ppsutil/util.go 42.35% <0.00%> (-1.28%) ⬇️
src/server/pfs/server/api_server.go 73.92% <0.00%> (-0.38%) ⬇️
src/internal/task/etcd_service.go 84.92% <0.00%> (-0.37%) ⬇️
src/server/pfs/server/driver.go 70.09% <0.00%> (-0.17%) ⬇️
src/pfs/pfs.pb.go 43.06% <0.00%> (-0.05%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@armaanv armaanv merged commit fb3e7c7 into 2.4.x Dec 8, 2022
@armaanv armaanv deleted the armaan/backportAudit branch December 8, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants