s3: log net/http errors at Debug level #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seslattery
approved these changes
Dec 16, 2022
|
I am not sure what's going on with govulncheck in this branch. I have the same version of Go and govulncheck as the CI machine, and don't get any warnings. After merging this PR, the govulncheck run on the 2.4.x branch passes. |
jrockway
added a commit
that referenced
this pull request
Dec 21, 2022
jrockway
added a commit
that referenced
this pull request
Dec 21, 2022
jrockway
added a commit
that referenced
this pull request
Dec 22, 2022
jrockway
added a commit
that referenced
this pull request
Dec 22, 2022
* make NewStdLog take a level; log http span at DebugLevel like we did for 2.4 in #8456 * s/[level]/level/ Co-authored-by: Robert Uhl <robert.uhl@pachyderm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.