Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4.x] Add number of tokens revoked to RevokeToken response (#8453) #8457

Merged
merged 1 commit into from Dec 21, 2022

Conversation

albscui
Copy link
Contributor

@albscui albscui commented Dec 16, 2022

  • Add number of tokens revoked to RevokeToken response

  • handle plurals properly

  • rename proto field from num to number

  • fix lint

* Add number of tokens revoked to RevokeToken response

* handle plurals properly

* rename proto field from num to number

* fix lint
@albscui albscui changed the title Add number of tokens revoked to RevokeToken response (#8453) [Backport 2.4.x] Add number of tokens revoked to RevokeToken response (#8453) Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #8457 (ce6d712) into 2.4.x (4adad7b) will decrease coverage by 36.50%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##            2.4.x    #8457       +/-   ##
===========================================
- Coverage   38.76%    2.25%   -36.51%     
===========================================
  Files         425      339       -86     
  Lines      117429   102706    -14723     
===========================================
- Hits        45516     2312    -43204     
- Misses      62775   100093    +37318     
+ Partials     9138      301     -8837     
Impacted Files Coverage Δ
src/auth/auth.pb.go 0.78% <0.00%> (-43.53%) ⬇️
src/server/auth/server/api_server.go 0.00% <0.00%> (-60.42%) ⬇️
src/server/auth/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/watch/op.go 0.00% <0.00%> (-100.00%) ⬇️
src/server/license/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/server/identity/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/dlock/dlock.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/testutil/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/log.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/dbutil/option.go 0.00% <0.00%> (-100.00%) ⬇️
... and 374 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jrockway jrockway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the pluralization!

@albscui albscui merged commit 5229825 into 2.4.x Dec 21, 2022
@albscui albscui deleted the albert/CORE-1337/backport branch December 21, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants