Gracefully handle old pipelines where output commit is ALIAS and meta commit is AUTO #8485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8485 +/- ##
===========================================
- Coverage 39.78% 2.36% -37.43%
===========================================
Files 455 365 -90
Lines 123023 107328 -15695
===========================================
- Hits 48950 2537 -46413
- Misses 64420 104446 +40026
+ Partials 9653 345 -9308
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrockway
approved these changes
Jan 4, 2023
| @@ -107,7 +107,8 @@ func (pj *pendingJob) load() error { | |||
| return errors.EnsureStack(err) | |||
| } | |||
| // both commits must have succeeded - a validation error will only show up in the output | |||
| if metaCI.Error == "" && outputCI.Error == "" { | |||
| // the commit must also not be of type ALIAS, to ensure that we have a corresponding job | |||
| if metaCI.Error == "" && outputCI.Error == "" && outputCI.Origin.Kind != pfs.OriginKind_ALIAS { | |||
There was a problem hiding this comment.
Do we want to add a log message around line 117 so we know which commit we picked as the base commit? Maybe it gets recorded elsewhere?
acohen4
force-pushed
the
acohen4/handle-alias-output-commit
branch
from
6f2e606
to
4f6f7e1
Compare
acohen4
added a commit
that referenced
this pull request
Jan 5, 2023
… commit is AUTO (#8485) Gracefully handle old pipelines where output commit is ALIAS and meta commit is AUTO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8116 we fixed an issue where ALIAS output commits would get created with corresponding AUTO meta commits. This didn't handle previously faulty DAGs. In this PR, we gracefully handle DAGs already containing the faulty structure.