Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4.x] Increase the reliability of debug dumps #8488

Merged
merged 2 commits into from Jan 5, 2023

Conversation

jrockway
Copy link
Member

@jrockway jrockway commented Jan 5, 2023

Backport #8472. This adds more timeouts to debug dumps, guarantees time within the RPC deadline to send back bytes, performs multiple erroring operations without bailing out, and lets pachctl control the timeout.

… little early so we can start sending bytes back when the timeout is near; try to dump thoroughly by using multierr rather than bailing out; add arbitrary timeouts to parts of the debug dump logic; make non-contexty things time out able (#8472)
@jrockway jrockway requested a review from albscui January 5, 2023 00:08
@jrockway jrockway changed the title [2.4.x] [2.4.x] Increase the reliability of debug dumps Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #8488 (f7110e1) into 2.4.x (5229825) will decrease coverage by 0.15%.
The diff coverage is 2.56%.

@@            Coverage Diff             @@
##            2.4.x    #8488      +/-   ##
==========================================
- Coverage   38.94%   38.79%   -0.16%     
==========================================
  Files         425      425              
  Lines      117494   117552      +58     
==========================================
- Hits        45761    45599     -162     
- Misses      62651    62810     +159     
- Partials     9082     9143      +61     
Impacted Files Coverage Δ
src/server/debug/server/database_dump.go 0.00% <0.00%> (ø)
src/server/debug/server/util.go 0.00% <0.00%> (ø)
src/server/debug/server/server.go 5.48% <1.39%> (-0.46%) ⬇️
src/server/debug/cmds/cmds.go 42.01% <33.33%> (-0.09%) ⬇️
src/internal/storage/chunk/renewer.go 54.54% <0.00%> (-27.28%) ⬇️
src/internal/miscutil/work_deduper.go 90.00% <0.00%> (-10.00%) ⬇️
src/internal/storage/fileset/prefetcher.go 73.91% <0.00%> (-5.80%) ⬇️
src/internal/require/require.go 42.53% <0.00%> (-4.88%) ⬇️
src/internal/storage/fileset/dir_inserter.go 76.19% <0.00%> (-4.77%) ⬇️
src/internal/transactionenv/txncontext/context.go 80.85% <0.00%> (-4.26%) ⬇️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jrockway jrockway merged commit 68170a4 into 2.4.x Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants