[Jupyter] Basic PPS UI #8557
[Jupyter] Basic PPS UI #8557
Conversation
|
Let's start a feature branch for the pipeline extension, which we merge into master once the pipeline extension is ready. |
| @@ -203,7 +217,22 @@ export class MountPlugin implements IMountPlugin { | |||
| ); | |||
| this._datum.addClass('pachyderm-mount-datum-wrapper'); | |||
|
|
|||
| this._pipeline = ReactWidget.create( | |||
There was a problem hiding this comment.
We touched upon this during the FE walkthrough with @pleeko in Miami, but we probably don't need to use signals here since the pipeline component doesn't have any properties/data that changes like the other components does. Signals are useful in the case where we see that some data has changed so we re-render the components that depend on that data. But since the pipeline component doesn't take any input that could change, we can remove signals.
Now, how this would look with no signals, I defer to Peter. It might actually just be removing the signal code lines that wrap the component and removing lines of code that emit to the corresponding signal.
There was a problem hiding this comment.
I removed the signal in a way that made sense to me, but I'll wait for Peter's feedback
jupyter-extension/src/plugins/mount/components/Pipeline/hooks/usePipeline.tsx
Outdated
Show resolved
Hide resolved
jupyter-extension/src/plugins/mount/components/Pipeline/Pipeline.tsx
Outdated
Show resolved
Hide resolved
jupyter-extension/src/plugins/mount/components/Pipeline/__tests__/Pipeline.test.tsx
Outdated
Show resolved
Hide resolved
jupyter-extension/src/plugins/mount/components/Pipeline/Pipeline.tsx
Outdated
Show resolved
Hide resolved
MVP UI for PPS extension. Nothing hooked up to the backend.
MVP UI for PPS extension. Nothing hooked up to the backend.
This is a very simple (first draft) of the UI for the PPS plugin for Jupyterlab. This doesn't include any backend calls. This my first PR for front end work so I'm sure a lot of it is incorrect, please tear it apart!
Question for @smalyala : I'm not sure that we want this merged into master yet (I don't know how the plugin releases are currently being done). Do you have thoughts about where this line of work should live?
Jira: INT-665