Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-1513] Correct project-already-exists error message #8628

Merged
merged 8 commits into from Mar 8, 2023

Conversation

robert-uhl
Copy link
Contributor

Turns out that the error message came from the collection package and indicated that the item in the “projects” table already existed.

Turns out that the error message came from the collection package and
indicated that the item in the “projects” table already existed.
@robert-uhl robert-uhl marked this pull request as ready for review March 6, 2023 18:49
@robert-uhl robert-uhl requested a review from albscui March 6, 2023 18:49
Copy link
Contributor

@albscui albscui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test?

src/server/pfs/server/driver.go Outdated Show resolved Hide resolved
@robert-uhl
Copy link
Contributor Author

Maybe add a test?

In this case, it’s just about the English which the user sees, so I figure not such a big deal.

@robert-uhl robert-uhl requested a review from albscui March 8, 2023 15:59
Copy link
Contributor

@albscui albscui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robert-uhl robert-uhl merged commit 9af9c7e into master Mar 8, 2023
@robert-uhl robert-uhl deleted the rau/core-1513-correct-plural branch March 8, 2023 21:48
bbonenfant pushed a commit that referenced this pull request Mar 9, 2023
* Correct project-already-exists error message

Turns out that the error message came from the collection package and
indicated that the item in the “projects” table already existed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants