Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-1500] Return error instead of deleting a project containing repos #8631

Merged
merged 6 commits into from Mar 7, 2023

Conversation

robert-uhl
Copy link
Contributor

No description provided.

@robert-uhl robert-uhl marked this pull request as ready for review March 7, 2023 14:57
@robert-uhl robert-uhl requested a review from jrockway March 7, 2023 14:57
Copy link
Member

@jrockway jrockway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We discussed on Slack a little bit... I wouldn't go to this much effort to make the error message nice. Just multierr.AppendInto for each repo existence, return err. An errors.SetGRPCStatus(&err, code) would be a nice utility function, however.

@robert-uhl robert-uhl merged commit 125a50e into master Mar 7, 2023
@robert-uhl robert-uhl deleted the rau/core-1500-error-when-repos-or-pipelines branch March 7, 2023 20:34
bbonenfant pushed a commit that referenced this pull request Mar 9, 2023
…os (#8631)

* Return error instead of deleting a project containing repos

* Delete all repos when deleting all in PFS

* Update test for new DeleteProject semantics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants