Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python-SDK] Fix CI linter #9217

Merged
merged 3 commits into from Aug 18, 2023
Merged

[Python-SDK] Fix CI linter #9217

merged 3 commits into from Aug 18, 2023

Conversation

bbonenfant
Copy link
Contributor

The linting was not being run on the source files.

@bbonenfant bbonenfant requested a review from a team as a code owner August 17, 2023 21:00
smalyala
smalyala approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@smalyala smalyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Where is it specified to run black linting when running pytest?

@bbonenfant
Copy link
Contributor Author

Nice! Where is it specified to run black linting when running pytest?

In the pyproject.toml file!

@bbonenfant bbonenfant merged commit eb710c4 into master Aug 18, 2023
34 of 35 checks passed
@bbonenfant bbonenfant deleted the bonenfant/fix-python-sdk-ci branch August 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalyala smalyala smalyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbonenfant @smalyala