New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter extension - allow configuration via env var #9615
Conversation
Kevin Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Just noting here: we learned during testing today that the token in For reference, cust-eng made a version of that change here |
f9552c5
to
57539a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I investigate the sdk a bit and saw similar code self.auth_token = self.auth.authenticate(id_token=oidc_token)
so I think this should work.
I did not pull it down to test though can do if you want me to.
else: | ||
get_logger().debug( | ||
"Could not find config file -- no pachyderm client instantiated" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add any tests for this new fallback behavior? I think we avoided testing setup_handlers before since it was so simple, but maybe given these branching paths it could be worthwhile now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of getting this into the release tomorrow, feel free to handle this in a follow up if you end up thinking it is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will file a ticket for this, i don't think it's very straightforward to toggle the env vars in our testing set up right now.
Allow the Pachyderm Jupyter extension address and token to be configured via env var for compatibility with the Determined launcher. [INT-1149](https://pachyderm.atlassian.net/browse/INT-1149) [INT-1149]: https://pachyderm.atlassian.net/browse/INT-1149?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Kevin Yang <kevin.yang@hpe.com>
Allow the Pachyderm Jupyter extension address and token to be configured via env var for compatibility with the Determined launcher. [INT-1149](https://pachyderm.atlassian.net/browse/INT-1149) [INT-1149]: https://pachyderm.atlassian.net/browse/INT-1149?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- [INT-1149]: https://pachyderm.atlassian.net/browse/INT-1149?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [INT-1149]: https://pachyderm.atlassian.net/browse/INT-1149?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Kevin Yang <kevin.yang@hpe.com>
Allow the Pachyderm Jupyter extension address and token to be configured via env var for compatibility with the Determined launcher.
INT-1149