[Backport - 2.8] Garbage Collect Determined Pipeline Users (#9491) [CORE-2131] #9658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.8.x #9658 +/- ##
==========================================
- Coverage 49.88% 49.83% -0.05%
==========================================
Files 565 565
Lines 69162 69252 +90
==========================================
+ Hits 34500 34515 +15
- Misses 31226 31307 +81
+ Partials 3436 3430 -6 ☔ View full report in Codecov by Sentry. |
robert-uhl
approved these changes
Jan 30, 2024
| "suite": "pachyderm", | ||
| "pipelineName": pipeline.Name, | ||
| "project": pipeline.GetProject().String(), | ||
| "determined": "true", |
There was a problem hiding this comment.
Rather than determined=true, I wonder if this should be type=determined or similar.
There was a problem hiding this comment.
great suggestion <3. I'll open a ticket for this and handle it in a separate PR
acohen4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.