Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport - 2.8] Change Auth Token Env Var Name #9687 #9693

Merged
merged 2 commits into from Jan 30, 2024

Conversation

BOsterbuhr
Copy link
Contributor

Use DEX_TOKEN instead of PACH_ID_TOKEN

Use DEX_TOKEN instead of PACH_ID_TOKEN
Copy link
Contributor

@acohen4 acohen4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 370 lines in your changes are missing coverage. Please review.

Comparison is base (6f11273) 49.91% compared to head (58f7741) 49.70%.
Report is 29 commits behind head on 2.8.x.

Files Patch % Lines
...c/internal/clusterstate/migrationutils/sanitize.go 33.83% 128 Missing and 3 partials ⚠️
src/server/pps/server/determined.go 9.25% 98 Missing ⚠️
src/internal/clusterstate/v2.8.0/pfsdb.go 61.03% 14 Missing and 16 partials ⚠️
src/internal/pfsdb/commits.go 70.29% 21 Missing and 9 partials ⚠️
src/server/pfs/server/driver.go 65.15% 16 Missing and 7 partials ⚠️
src/internal/pfsdb/repos.go 72.22% 10 Missing and 5 partials ⚠️
src/internal/pfsdb/branches.go 85.07% 6 Missing and 4 partials ⚠️
...internal/clusterstate/migrationutils/pg_batcher.go 68.96% 5 Missing and 4 partials ⚠️
src/server/pfs/cmds/cmds.go 46.66% 8 Missing ⚠️
src/server/pps/server/api_server.go 0.00% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##            2.8.x    #9693      +/-   ##
==========================================
- Coverage   49.91%   49.70%   -0.21%     
==========================================
  Files         565      565              
  Lines       68953    69252     +299     
==========================================
+ Hits        34417    34425       +8     
- Misses      31078    31362     +284     
- Partials     3458     3465       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BOsterbuhr BOsterbuhr merged commit 1c9912c into 2.8.x Jan 30, 2024
25 checks passed
@BOsterbuhr BOsterbuhr deleted the bosterbuhr/backport-change-token-name branch January 30, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants