New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jupyter] Tabs (lumino) #9696
[Jupyter] Tabs (lumino) #9696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Really like this approach compared to the prior SplitPanel model. Just a few comments mostly some questions for learning purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Good find. I was able to reproduce this off of master, so I don't think this is a new addition from these changes. I created a ticket for that here. I also notice that when you enter an invalid pachd address you get an error message and the field goes blank. That's also not new but should be fixed as well |
This implements a Tab layout of the extension using some builtin `lumino` functionality. This shifts us away from a UI model that that can be summarized as "explore view with a bunch of child views which we manually show and hide" to "views split between tabs that the user can 'freely' navigate between". To minimize the amount of changes included in this PR, we still have some situations where we force the user into certain views, such as: * when the user is not connected to/logged into a cluster they are brought to the config screen, * if a server error happens we show a full screen error. To accomplish this I had to make the following changes: * Move the "explore" view into a component, * Remove all of the showConfig/showDatum/showPipeline/etc. flags and signals as they are no longer needed, * Collapsed the Pipeline and PipelineSplash screens into the same react component,
This implements a Tab layout of the extension using some builtin
lumino
functionality. This shifts us away from a UI model that that can be summarized as "explore view with a bunch of child views which we manually show and hide" to "views split between tabs that the user can 'freely' navigate between". To minimize the amount of changes included in this PR, we still have some situations where we force the user into certain views, such as:To accomplish this I had to make the following changes:
Some additional notes:
Screen Recording:
https://github.com/pachyderm/pachyderm/assets/28938409/caee8215-c041-4073-8d60-ca54abeaf8ab