Remove PACHD_ADDRESS deprecation warning #9703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PACHD_ADDRESS is no longer deprecated as it is being used in determined notebooks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9703 +/- ##
=======================================
Coverage 58.93% 58.94%
=======================================
Files 583 583
Lines 71193 71192 -1
=======================================
+ Hits 41958 41964 +6
+ Misses 28617 28604 -13
- Partials 618 624 +6 ☔ View full report in Codecov by Sentry. |
acohen4
approved these changes
Mar 19, 2024
When using pachctl in a det notebook we are using |
BOsterbuhr
added a commit
that referenced
this pull request
Mar 19, 2024
PACHD_ADDRESS is no longer deprecated as it is being used in determined notebooks.
BOsterbuhr
added a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PACHD_ADDRESS is no longer deprecated as it is being used in determined notebooks.