Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListRepo() gRPC pagination [CORE-2132] #9727

Merged
merged 6 commits into from Feb 26, 2024
Merged

Conversation

acohen4
Copy link
Contributor

@acohen4 acohen4 commented Feb 13, 2024

No description provided.

src/pfs/pfs.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@kevyang kevyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp for integrations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes will break the JupyterLab extension. We will need to make sure the python-sdk release that the extension is built with matches the extension code. I will file a ticket to track this work.

Copy link
Contributor

@FahadBSyed FahadBSyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the page parameter in ForEachRepo() and in hindsight I wish we had grouped the parameters better during the postgres migration since the signature is starting to get complicated.

That is out of scope for your change though. I think given the constraints of the codebase, this is probably the best way to implement paging.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.19%. Comparing base (0125adc) to head (96b3844).
Report is 3 commits behind head on master.

Files Patch % Lines
src/internal/pfsdb/repos.go 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9727      +/-   ##
==========================================
- Coverage   59.22%   59.19%   -0.04%     
==========================================
  Files         583      583              
  Lines       69943    69966      +23     
==========================================
- Hits        41425    41416       -9     
- Misses      27928    27956      +28     
- Partials      590      594       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acohen4 acohen4 merged commit 82e40fa into master Feb 26, 2024
21 checks passed
@acohen4 acohen4 deleted the acohen4/paginate-repos branch February 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants