New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListRepo() gRPC pagination [CORE-2132] #9727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp for integrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes will break the JupyterLab extension. We will need to make sure the python-sdk release that the extension is built with matches the extension code. I will file a ticket to track this work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about the page parameter in ForEachRepo() and in hindsight I wish we had grouped the parameters better during the postgres migration since the signature is starting to get complicated.
That is out of scope for your change though. I think given the constraints of the codebase, this is probably the best way to implement paging.
a219e3f
to
d615e7d
Compare
d615e7d
to
d00993c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9727 +/- ##
==========================================
- Coverage 59.22% 59.19% -0.04%
==========================================
Files 583 583
Lines 69943 69966 +23
==========================================
- Hits 41425 41416 -9
- Misses 27928 27956 +28
- Partials 590 594 +4 ☔ View full report in Codecov by Sentry. |
No description provided.