[INT-1190] Center gear tab #9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmajsadams
requested review from
a team and
bbonenfant
and removed request for
a team
|
lol first time I use the INT team random assignment and it still goes to you Ben 😆 |
msteffen
added a commit
that referenced
this pull request
Mar 6, 2024
Backport of #9761 for [INT-1190] [INT-1190]: https://pachyderm.atlassian.net/browse/INT-1190?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Emma Adams <emma.adams@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gear tab was slightly off center both vertically and horizontally. Since it is an svg the best way to fix this is by applying a transform in pixels to correct this. The transform will ensure that regardless of the position of the svg on the page it is offset by exactly that much relative to it's position in the parent element. I measured the center using the screenshot tool and it should be exactly 46 pixels from all four sides.