Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync values for upgrades #9763

Merged
merged 1 commit into from Feb 26, 2024
Merged

Conversation

djanicekpach
Copy link
Contributor

For Determined tests, we needed to set createNonNamespacedObjects. My original fix for this, only worked on initial deploy and I missed upgrades. For upgrades we also need to keep both options in sync so that the upgrade can know if it needs to keep the Priority Classes or not. Installing with priority classes, and then not including them on a subsequent update breaks the upgrade.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.24%. Comparing base (82e40fa) to head (54dad23).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9763      +/-   ##
==========================================
+ Coverage   59.19%   59.24%   +0.04%     
==========================================
  Files         583      583              
  Lines       69966    69971       +5     
==========================================
+ Hits        41415    41452      +37     
+ Misses      27965    27946      -19     
+ Partials      586      573      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djanicekpach djanicekpach force-pushed the djanicek/infraeng-430/values-set-logic branch from 8d62fd4 to 54dad23 Compare February 26, 2024 15:26
@djanicekpach djanicekpach merged commit c05d961 into master Feb 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants