[PFS-207] Add Picker Protos #9788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pfs/pfs.proto
Outdated
| string id = 2; | ||
| } | ||
|
|
||
| // TODO: add a picker option to pick commit by uuid. |
There was a problem hiding this comment.
I think these are used for public documentation. I'd remove internal comments like TODOs.
brendoncarroll
approved these changes
Mar 4, 2024
brendoncarroll
approved these changes
Mar 4, 2024
…m into PFS-207-picker-protos
bbonenfant
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
This looks good to me. The INT team is probably going to want to write some code to wrap these objects and make these a little nicer to use; similar to what we did here. I'll make a ticket to track this.
|
Hey folks, I'm just going to rebase this off master, run a quick |
FahadBSyed
force-pushed
the
PFS-207-picker-protos
branch
from
96fad58
to
9b1f6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds picker protos and their auto-generated code changes. The implementations of the pickers will be in a follow-up PR.