jupyter extension - add tests for env var configuration #9809
Conversation
|
Kevin Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -664,11 +665,11 @@ def setup_handlers(web_app, config_file: Path): | |||
| f"Created Pachyderm client for {client.address} from local config" | |||
| ) | |||
| except FileNotFoundError: | |||
| if PACHD_ADDRESS: | |||
There was a problem hiding this comment.
unrelated to this PR, but just clarifying. We want to use pachd_address/dex_token passed through env vars only if no config file is present? And then it doesn't appear that this is written to a config file - should it be?
There was a problem hiding this comment.
that is correct. good call on this not writing to config file, i think it makes sense to write it. i have added that logic and added testing for it.
| @@ -30,7 +30,18 @@ def pach_config(request, tmp_path) -> Path: | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def app(pach_config) -> tornado.web.Application: | |||
| def pach_config_env_var(request) -> str: | |||
There was a problem hiding this comment.
Bit of a nit, but this name seems misleading to me, and the marker name seems a little vague. Could they be something like pachd_address_env_var?
[INT-1229](https://pachyderm.atlassian.net/browse/INT-1229) [INT-1229]: https://pachyderm.atlassian.net/browse/INT-1229?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Kevin Yang <kevin.yang@hpe.com>
[INT-1229](https://pachyderm.atlassian.net/browse/INT-1229) [INT-1229]: https://pachyderm.atlassian.net/browse/INT-1229?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- [INT-1229]: https://pachyderm.atlassian.net/browse/INT-1229?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [INT-1229]: https://pachyderm.atlassian.net/browse/INT-1229?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Kevin Yang <kevin.yang@hpe.com>
INT-1229