Make testpachd a runnable binary #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrockway
force-pushed
the
jonathan/runnable-testpachd
branch
from
f81933b
to
1598552
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9887 +/- ##
===========================================
+ Coverage 41.64% 57.96% +16.32%
===========================================
Files 548 607 +59
Lines 65290 73907 +8617
===========================================
+ Hits 27188 42840 +15652
+ Misses 36046 30511 -5535
+ Partials 2056 556 -1500 ☔ View full report in Codecov by Sentry. |
robert-uhl
reviewed
Mar 28, 2024
There was a problem hiding this comment.
I believe that this can be rewritten to not need the cleanup package at all, or perhaps use it internally, by e.g. running in one function and deferring release of resources until the end, or by allocating resources, returning and deferring a close/release in the caller.
jrockway
force-pushed
the
jonathan/runnable-testpachd
branch
from
65504d0
to
d8caafe
Compare
jrockway
force-pushed
the
jonathan/runnable-testpachd
branch
from
d8caafe
to
0b07006
Compare
|
Please take another look. @Zhang-Muyang you have to approve if you're OK with the changes from PFS's perspective, a comment saying "looks good" won't do it. |
Zhang-Muyang
approved these changes
Mar 29, 2024
zmajeed
pushed a commit
that referenced
this pull request
Apr 2, 2024
This makes testpachd runnable with `bazel run //src/testing/testpachd`. It will automatically setup a pachctl context when the server is ready, and restore to whatever you had before when exiting. This should eliminate most of integrations' need to use k8s in their tests, which will make their tests much faster. It's also handy for local debugging, of course. Unrelated change: while I was in here, I made the grpc validation interceptor not log a warning during health checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes testpachd runnable with
bazel run //src/testing/testpachd.It will automatically setup a pachctl context when the server is ready, and restore to whatever you had before when exiting.
Right now you can't activate auth, but in #9886 I made testpachd auth-ready, so when that is merged I will add an "activateAuth" flag to start it up with auth.
This should eliminate most of integrations' need to use k8s in their tests, which will make their tests much faster. It's also handy for local debugging, of course.
@pachyderm/pfs review is required because I refactored a utility function to not need a *testing.T, and updated a caller in src/server/pfs/testing.
Unrelated change: while I was in here, I made the grpc validation interceptor not log a warning during health checks.