Add extraArgs to debug dumps; use them to specify number of lines from Loki and which profiles to grab.

[jrockway]

A template now looks like this:

$ pachctl debug template
defaults:
    clusterDefaults: true
inputRepos: true
starlarkScripts:
    - builtin: starlark/basic.star
      timeout: 60s
    - builtin: starlark/list_rcs.star
      timeout: 60s
system:
    database: true
    describes:
        - name: console                                                                                                                                                                                                                                                     - name: etcd
        - name: pachd
        - name: pachyderm-kube-event-tail
        - name: pachyderm-proxy
        - name: pg-bouncer
    helm: true
    logs:
        - name: console
        - name: etcd
        - name: pachd
        - name: pachyderm-kube-event-tail
        - name: pachyderm-proxy
        - name: pg-bouncer
    lokiLogs:
        - lokiArgs:
            maxLogs: "30000"
          name: console
        - lokiArgs:
            maxLogs: "30000"
          name: etcd
        - lokiArgs:
            maxLogs: "30000"
          name: pachd
        - lokiArgs:
            maxLogs: "30000"
          name: pachyderm-kube-event-tail
        - lokiArgs:
            maxLogs: "30000"
          name: pachyderm-proxy
        - lokiArgs:
            maxLogs: "30000"
          name: pg-bouncer
    profiles:
        - name: pachd
          profileArgs:
            profiles:
                - name: heap
                - name: goroutine
    version: true

This means you can now specify how many lines Loki should get you, and which profiles to run. You can do a CPU profile like:

system:
  profiles:
    - name: pachd
      profileArgs:
        profiles:
          - name: cpu
            duration: 30s

The n in name is low in alphabetical order so the generated template doesn't sort for optimal readability. This is unavoidable ;)

[acohen4]

Looks good! My only comment is around making separate, typed args in the API

[codecov]

Codecov Report

Attention: Patch coverage is 77.08333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 58.07%. Comparing base (97cc201) to head (e0fb76c).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/server/debug/server/server.go	77.08%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9888      +/-   ##
==========================================
- Coverage   58.07%   58.07%   -0.01%     
==========================================
  Files         606      606              
  Lines       73534    73572      +38     
==========================================
+ Hits        42708    42730      +22     
- Misses      30264    30280      +16     
  Partials      562      562              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.