PipelinesSummary RPC [CORE-2211] #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acohen4
force-pushed
the
acohen4/pipelines-summary
branch
2 times, most recently
from
b6fcd9a
to
0060db1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9889 +/- ##
==========================================
- Coverage 58.26% 58.19% -0.07%
==========================================
Files 612 612
Lines 74722 74777 +55
==========================================
- Hits 43537 43518 -19
- Misses 30641 30708 +67
- Partials 544 551 +7 ☔ View full report in Codecov by Sentry. |
robert-uhl
reviewed
Apr 1, 2024
bbonenfant
reviewed
Apr 8, 2024
acohen4
force-pushed
the
acohen4/pipelines-summary
branch
from
f90cf53
to
9d54876
Compare
robert-uhl
approved these changes
Apr 16, 2024
bbonenfant
approved these changes
Apr 16, 2024
src/pps/pps.proto
Outdated
| } | ||
|
|
||
| message PipelinesSummary { | ||
| pfs_v2.Project project = 1; // the project the PipelinesSummary corresponds to |
There was a problem hiding this comment.
Please move these comments above the fields as well, for consistency
zmajeed
pushed a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.