Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go 1.22.1 #9891

Merged
merged 9 commits into from Mar 29, 2024
Merged

upgrade to go 1.22.1 #9891

merged 9 commits into from Mar 29, 2024

Conversation

acohen4
Copy link
Contributor

@acohen4 acohen4 commented Mar 26, 2024

MODULE.bazel needs to be edited around here:

go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
go_sdk.nogo(nogo = "//:nogo")
go_sdk.download(
    name = "go_sdk",
    version = "1.21.8",    # <-----
)
use_repo(go_sdk, "go_sdk")

@jrockway
Copy link
Member

This CI failure is a bug with CI that's fixed in master. I would just merge this if you need it.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (6b165f8) to head (e3b6965).

Additional details and impacted files
@@            Coverage Diff             @@
##            2.9.x    #9891      +/-   ##
==========================================
- Coverage   59.13%   59.00%   -0.13%     
==========================================
  Files         584      584              
  Lines       71291    71291              
==========================================
- Hits        42156    42067      -89     
- Misses      28512    28594      +82     
- Partials      623      630       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrockway jrockway merged commit b5ce331 into 2.9.x Mar 29, 2024
33 checks passed
@robert-uhl robert-uhl deleted the acohen4/2_9-go_1_22 branch March 29, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants