read CommitInfo before overwriting it with stale data #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrockway
force-pushed
the
jonathan/testpachd-with-pfs-master-txn-fix
branch
from
97c45d7
to
03f5558
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9892 +/- ##
==========================================
- Coverage 58.32% 58.22% -0.10%
==========================================
Files 604 604
Lines 73186 73188 +2
==========================================
- Hits 42683 42614 -69
- Misses 29958 30033 +75
+ Partials 545 541 -4 ☔ View full report in Codecov by Sentry. |
jrockway
force-pushed
the
jonathan/testpachd-with-pfs-master-txn-fix
branch
from
03f5558
to
678bc2d
Compare
zmajeed
pushed a commit
that referenced
this pull request
Apr 2, 2024
Refresh CommitInfo before overwriting it. This avoids a rare race: A commit is created. Finalization starts. Metadata on the commit is changed. The metadata update is overwritten when the PFS master writes the finalization time / status to the commit. The metadata tests are fast enough to cause this, and it happened pretty consistently. This probably needs to be done in more places; we should always read before writing when only changing one field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh CommitInfo before overwriting it. This avoids a rare race:
A commit is created.
Finalization starts.
Metadata on the commit is changed.
The metadata update is overwritten when the PFS master writes the finalization time / status to the commit.
The metadata tests are fast enough to cause this, and it happened pretty consistently.
This probably needs to be done in more places; we should always read before writing when only changing one field.