[CORE-2189] Add dynamic log pages #9898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9898 +/- ##
==========================================
+ Coverage 58.16% 58.26% +0.09%
==========================================
Files 611 612 +1
Lines 74543 74685 +142
==========================================
+ Hits 43359 43515 +156
+ Misses 30639 30623 -16
- Partials 545 547 +2 ☔ View full report in Codecov by Sentry. |
A quick search through our commands didn’t turn up any existing time flags.
Seems more idiomatic to me.
…-dynamic-log-pages
Due to looking for the previous log dynamically, one will not be found if it does not exist.
Retry invalid batch size once, and use constants rather than magic strings for log direction.
…m/pachyderm into rau/core-2189-dynamic-log-pages
…-2189-dynamic-log-pages
…m/pachyderm into rau/core-2189-dynamic-log-pages
zmajeed
approved these changes
Apr 12, 2024
|
The Apache-2.0–licensed code used in this PR ultimately comes from Loki commit 6e67d1e via Loki commit 3c78579; we have a previously-approved use of Loki commit 6e67d1e via Loki commit a9d85de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts code from Loki’s logcli. Note that this version of logcli was made available under the Apache License 2.0.