Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to deflake the consistenthashing tests #9943

Merged
merged 3 commits into from Apr 11, 2024

Conversation

jrockway
Copy link
Member

@jrockway jrockway commented Apr 10, 2024

I can get this to fail when I run 64 copies of the tests simultaneously. While I was doing that I noticed that the etcd logs were complaining about some operations being too slow. Since no CPU was being used while this was going on, I assumed it was a disk problem. Disabling fsync for etcd made the parallel runs all complete in a max of 30 seconds or average of 7 seconds, down from 600 seconds and timing out. So I think this is the magic sauce that was needed. It probably helps other tests, since pretty much everything eventually depends on testetcd.

While working on fixing this test, I noticed that the Loki tests are pretty flaky. That is fixed in #9945.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.98%. Comparing base (2463e32) to head (9a41651).

Files Patch % Lines
src/internal/pachd/testpachd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9943      +/-   ##
==========================================
- Coverage   58.15%   57.98%   -0.18%     
==========================================
  Files         610      610              
  Lines       74140    74142       +2     
==========================================
- Hits        43114    42988     -126     
- Misses      30477    30597     +120     
- Partials      549      557       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrockway jrockway merged commit d478f50 into master Apr 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants