Attempt to deflake the consistenthashing tests #9943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can get this to fail when I run 64 copies of the tests simultaneously. While I was doing that I noticed that the etcd logs were complaining about some operations being too slow. Since no CPU was being used while this was going on, I assumed it was a disk problem. Disabling fsync for etcd made the parallel runs all complete in a max of 30 seconds or average of 7 seconds, down from 600 seconds and timing out. So I think this is the magic sauce that was needed. It probably helps other tests, since pretty much everything eventually depends on testetcd.
While working on fixing this test, I noticed that the Loki tests are pretty flaky. That is fixed in #9945.