Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peek functionality to index reader and use it in the file source (2.8.x) #9961

Merged
merged 1 commit into from Apr 24, 2024

Conversation

brycemcanally
Copy link
Contributor

No description provided.

@brycemcanally brycemcanally requested a review from a team as a code owner April 19, 2024 13:49
@FahadBSyed FahadBSyed requested review from FahadBSyed and removed request for Zhang-Muyang April 19, 2024 13:56
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.85%. Comparing base (a90d866) to head (d9dfabd).

Additional details and impacted files
@@            Coverage Diff             @@
##            2.8.x    #9961      +/-   ##
==========================================
+ Coverage   49.72%   49.85%   +0.13%     
==========================================
  Files         565      565              
  Lines       69254    69270      +16     
==========================================
+ Hits        34435    34537     +102     
+ Misses      31353    31302      -51     
+ Partials     3466     3431      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if idx.File != nil {
if atEnd(idx.Path, r.filter) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks intentional, but just to confirm: Do we only want to peek if the next file index is past the range?
Otherwise, it looks like range indices will continue to be read until we get to the next file index.

I assume this is needed so we emit the peeked file, maybe that's something worth calling out with a comment so it doesn't have to be inferred and we're aware of that later if we need to modify this code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we want to check the first file index after the end of the path range. This may involve traversing additional range indexes if the end of the path range lines up with a chunk boundary.

@brycemcanally brycemcanally changed the title Add peek functionality to index reader and use it in the file source Add peek functionality to index reader and use it in the file source (2.8.x) Apr 24, 2024
@brycemcanally brycemcanally merged commit 5ab5ad0 into 2.8.x Apr 24, 2024
25 checks passed
@brycemcanally brycemcanally deleted the path-range-filtering-perf-2.8.x branch April 24, 2024 14:51
brycemcanally added a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants