[CORE-2214] pachctl datum logs #9962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derm/pachyderm into rau/core-2129-datum-logs-follow-on
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9962 +/- ##
==========================================
- Coverage 58.26% 57.85% -0.42%
==========================================
Files 612 612
Lines 74827 74846 +19
==========================================
- Hits 43600 43300 -300
- Misses 30675 31002 +327
+ Partials 552 544 -8 ☔ View full report in Codecov by Sentry. |
jrockway
approved these changes
Apr 19, 2024
| if cmd.Flag("project").Changed || cmd.Flag("pipeline").Changed { | ||
| fmt.Fprintln(os.Stderr, "only one of [--logQL | --project PROJECT --pipeline PIPELINE] may be set") | ||
| if cmd.Flag("project").Changed || cmd.Flag("pipeline").Changed || cmd.Flag("datum").Changed { | ||
| fmt.Fprintln(os.Stderr, "only one of [--logQL | --project PROJECT --pipeline PIPELINE | --datum DATUM] may be set") |
There was a problem hiding this comment.
I think that return errors.New(...) has the same effect with how we have everything set up.
There was a problem hiding this comment.
There’s no return value to the Run function. Maybe it should be RunE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.