-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PFS-241] Require storageURL if gocdkEnabled: true #9978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates pachw as well for consistency
BOsterbuhr
requested review from
brendoncarroll,
molinamelendezj and
Zhang-Muyang
April 23, 2024 21:43
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9978 +/- ##
==========================================
+ Coverage 58.25% 58.37% +0.11%
==========================================
Files 612 612
Lines 75173 75173
==========================================
+ Hits 43794 43880 +86
+ Misses 30819 30736 -83
+ Partials 560 557 -3 ☔ View full report in Codecov by Sentry. |
molinamelendezj
approved these changes
Apr 24, 2024
Zhang-Muyang
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the helm deployment templates of
pachd
andpachw
to requirepachd.storage.storageURL
be set ifpachd.storage.gocdkEnabled
is true