Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make collections methods take a context #9989

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Conversation

jrockway
Copy link
Member

@jrockway jrockway commented Apr 25, 2024

This reworks the collections package to avoid embedded contexts. This is especially important for ReadWrite transactions, which didn't use contexts at all. This resulted in many operations, especially related to auth, blocking indefinitely when Postgres was broken. That's now fixed.

This replaces PR #9947.

Part of CORE-2246

@jrockway jrockway requested review from a team as code owners April 25, 2024 16:48
@jrockway jrockway requested review from zmajeed, Zhang-Muyang and robert-uhl and removed request for zmajeed April 25, 2024 16:48
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 82.21757% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 58.19%. Comparing base (05a6179) to head (bc59d4a).
Report is 2 commits behind head on master.

Files Patch % Lines
src/internal/testpachd/mock_pachd.go 0.00% 30 Missing ⚠️
src/server/pps/server/s3g_sidecar.go 0.00% 18 Missing ⚠️
src/internal/collection/transaction.go 70.37% 8 Missing ⚠️
src/server/pps/server/api_server.go 91.07% 2 Missing and 3 partials ⚠️
src/server/worker/driver/driver.go 16.66% 5 Missing ⚠️
src/internal/collection/etcd_collection.go 95.58% 3 Missing ⚠️
src/internal/collection/postgres_collection.go 95.71% 3 Missing ⚠️
src/internal/tracing/extended/extended_trace.go 0.00% 3 Missing ⚠️
src/internal/clusterstate/v2.5.0/auth.go 60.00% 2 Missing ⚠️
src/server/worker/pipeline/transform/registry.go 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9989      +/-   ##
==========================================
- Coverage   58.25%   58.19%   -0.06%     
==========================================
  Files         614      614              
  Lines       75510    75506       -4     
==========================================
- Hits        43988    43942      -46     
- Misses      30968    31010      +42     
  Partials      554      554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robert-uhl robert-uhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@jrockway jrockway merged commit 07bc31b into master Apr 25, 2024
21 checks passed
jrockway added a commit that referenced this pull request Apr 29, 2024
This reworks the collections package to avoid embedded contexts. This is
especially important for ReadWrite transactions, which didn't use
contexts at all. This resulted in many operations, especially related to
auth, blocking indefinitely when Postgres was broken. That's now fixed.

This replaces PR #9947.

Part of CORE-2246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants