Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new format of decision tables shown in Table B.3 of 2021 assessment? #855

Closed
andrew-edwards opened this issue Dec 14, 2021 · 18 comments

Comments

@andrew-edwards
Copy link
Collaborator

In 2021 several suggested changes were made to the format of the big decision tables, resulting in Table B.3. The SRG said:

" The SRG believes that the resulting decision tables are clearer and easier to understand and recommends that the JMC review these tables along with the standard decision tables, and provide feedback to the SRG and JTC as to its preference during the March 15-17, 2021 JMC Meeting. These alternative decision tables are presented in Appendix B of the JTC Stock Assessment document." [wasn't actually in the list of recommendations though]

At JMC we asked for feedback - I don't have my meeting notes handy and forget what they said. Kelli has followed up with Jim but not heard back.

Given the SRG prefers them, and if we don't recall anyone being against them, seems we should use them. We justified and explained the differences in 2021 Appendix B (so no need to again), including Trevor's 2019 one about the catch/biomass years being offset in #553. Code is all written.

@andrew-edwards
Copy link
Collaborator Author

andrew-edwards commented Dec 14, 2021

So in Exec Summary would update:

  • Table g & h
  • Figure i add the extra projection year
  • Add extra Table i/j for the extra year, plus extra Figure j/k for the extra year

@andrew-edwards
Copy link
Collaborator Author

JTC internal meeting: agreed to do this. Decide upon exact catch streams later - maybe even non-equal from year to year if JMC get back to us. Easier to add further catch streams to big table than do a second table - okay if ends up as a long table over two pages.

@andrew-edwards andrew-edwards self-assigned this Jan 6, 2022
@andrew-edwards
Copy link
Collaborator Author

Maybe on Friday we should just mention to the JMC that we're doing the new format as recommended by the SRG. If any objections we can stick with the usual.

@andrew-edwards
Copy link
Collaborator Author

Not sure that we actually showed an updated format for the relative fishing intensity table. Chris put a type = "spr" option into the new_decision_table() function, but it didn't work when I quickly tried it. So I haven't put that new format of table into main-tables yet (which I think would just be losing the % signs everywhere and losing the 25% and 75% columns). Have copied new format of biomass table into main-tables (but not Exec Summary yet - tweak it first as necessary in main-tables then copy over).

@cgrandin
Copy link
Collaborator

cgrandin commented Jan 7, 2022

I didn’t write the code for that table yet

@andrew-edwards
Copy link
Collaborator Author

Thanks - that's what I thought. Got a bit confused because the SRG talked about showing alternative tables in App B, but we only had the biomass one.

@andrew-edwards
Copy link
Collaborator Author

andrew-edwards commented Jan 20, 2022

All done except Chris to update the fishing intensity table if time (else I can do it - I can see what lines to tweak). No text updated yet.

Managed to get all the catch options into single tables.

@aaronmberger-nwfsc
Copy link
Collaborator

I think we only need 3 rows per catch stream for the fishing intensity decision table. The SRG wanted to see the result of the 2024 catch in terms of beginning of the year SSB (2025 SSB). So if we include the 2025 catch row in the fishing intensity table we are in the same situation just with another year added. When altering this table, I think we can remove 2025 row from each catch stream which then will also make it shorter and fit on a page like the SSB one does.

@cgrandin
Copy link
Collaborator

@aaronmberger-nwfsc are you saying it should look exactly like this rel. biomass one then with the "start year" column? I thought there was some difference

image

@andrew-edwards
Copy link
Collaborator Author

I don't think we need the "Biomass year Start 2022" column. Will actually be confusing (and is the thing I figured might be a bit fiddly in the code).

@cgrandin
Copy link
Collaborator

@andrew-edwards I am talking about the Relative Fishing intensity table, are you also?

@cgrandin
Copy link
Collaborator

cgrandin commented Jan 24, 2022

I thought we agreed to project 4 years, so we show 2025 relative fishing intensity for the catch stream because it is the 4th year. So we show the 2025 catch value. We don't show the resulting biomass of that catch in the relative biomass table because it would mean we have to project this model 5 years.

@aaronmberger-nwfsc
Copy link
Collaborator

Yes, we still project 4 years, but don't show 2025 (fishing intensity table only). Right, the whole point was that previously we showed fishing intensity for a year but did not show the result of that fishing (i.e., the biomass at the start of the next year). Does that make sense?

@cgrandin
Copy link
Collaborator

So the sole reason to project 4 years is so we could show the 4th year start-of-year biomass after the last year's fishing. And not show the fishing intensity for that 4th year even though we have it. I think I have it right now

@andrew-edwards
Copy link
Collaborator Author

Agree with Aaron. We're always going to kind of be off by one year. Three rows for this table.

@andrew-edwards
Copy link
Collaborator Author

And the table will have three rows like the snippet shown above. I said remove the "Biomass year Start 2022" for this table as we're not showing biomass at all and it might be confusing. (Unless it's too fiddly to take out).

@andrew-edwards
Copy link
Collaborator Author

Good job with the new fishing intensity table Chris. I noticed that the numbers are proportions now rather than percentages (like in the relative spawning biomass table), which is neater. Presume everyone is good with that.

I'll fix the caption (still says %ages), plus the main-tables equivalent, plus add it to the age-1 index appendix as I think it's not there.

image

@cgrandin
Copy link
Collaborator

cgrandin commented Jan 26, 2022

Thanks Andy. Note that I swapped the quantiles (5%, 50%, and 95%) with the "Relative fishing Intensity" text and removed the "Model quantile" text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants