-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct CartAPI URL from OS environment variables #15
Construct CartAPI URL from OS environment variables #15
Conversation
@dmlb2000 In https://github.com/pacifica/pacifica-python-downloader/pull/15/files#diff-d8e165b4149566ddfdab844d646f4d6fR51, the prefix for environment variables for the |
@markborkum We've been standardizing on |
@dmlb2000 Also, should we take the opportunity to add more |
@markborkum Yes more logging the better really. |
Commit 3449fb7 did not resolve merge conflicts.
@dmlb2000 CI is failing due to |
@markborkum Yes, autopep8 is kinda lame, I would look for long lines and split them up...
becomes
|
@dmlb2000 Ready for review. |
Description
This pull request modifies the constructors for the
Downloader
andCartAPI
classes so that CartAPI URLs are automatically constructed from either user-specified keyword arguments or OS environment variables.The intent is that the type signature for the constructor for the
Downloader
class should resemble that of theUploader
(e.g., use keyword arguments to specify and/or construct URLs).Changes:
CommonBase
class using code from https://github.com/pacifica/pacifica-python-uploader/blob/master/pacifica/uploader/common/__init__.py.auth
property fromDownloader
class. For a given instanced
, used.cart_api._auth
instead ofd.auth
.Issues Resolved
n/a
Check List