Store climo bounds in TimeSet.start_date, end_date for mym files #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d680b88)
(cherry picked from commit 656c23d)
(Fix merge error.)
Also use datetime.utcnow instead of datetime.now so that modtime from file system is directly comparable with index time in database (cherry picked from commit 02555ff)
|
@jameshiebert , while you're in a PR-merging mood, do you feel good about this one too? |
jameshiebert
requested changes
Jul 20, 2017
| @@ -59,6 +59,8 @@ | |||
| import functools | |||
| from argparse import ArgumentParser | |||
|
|
|||
| from dateutil.relativedelta import relativedelta | |||
There was a problem hiding this comment.
dateutil is an undeclared dependency and should be added to setup.py and requirements.txt.
mm_cataloguer/index_netcdf.py
Outdated
| start_date = climatology_bounds[0][0] + relativedelta(months=1) | ||
| end_date = climatology_bounds[-1][1] + relativedelta(months=1) | ||
| else: | ||
| raise ValueError("Unexpected value '{}' for time_resolution in " |
There was a problem hiding this comment.
It might be worth informing the user as to what you do expect.
jameshiebert
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For data files containing multi-year means, we need the climatology bounds as well as the time values. See pacificclimate/climate-explorer-backend#50
Currently,
TimeSet.start_date,end_datealways contain the naive min and max values of the time variable. For multi-year mean files, this should be the climatological bounds.This PR:
tiny_climo_gcm) into standards-compliant monthly, seasonal, and yearly test files.