Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce valid-identifier syntax on meta_vars.net_var_name #183

Open
rod-glover opened this issue Sep 7, 2023 · 0 comments
Open

Enforce valid-identifier syntax on meta_vars.net_var_name #183

rod-glover opened this issue Sep 7, 2023 · 0 comments
Assignees
@Nospamas

Comments

@rod-glover
Copy link
Contributor

See pacificclimate/pdp_util#44 for why.
@rod-glover rod-glover transferred this issue from pacificclimate/pdp_util Sep 7, 2023
@rod-glover rod-glover mentioned this issue Dec 13, 2023
Closed
Nospamas added a commit that referenced this issue Jan 8, 2024
@Nospamas
#183 Add check constraint to meta_vars.net_var_name to prevent whites…
386fc7a 
…pace
Nospamas added a commit that referenced this issue Jan 8, 2024
@Nospamas
#183 Fix orm constraint negation. Fix existing test data.
e925cce
Nospamas added a commit that referenced this issue Jan 8, 2024
@Nospamas
#183 Run black
9bcedc7
Nospamas added a commit that referenced this issue Jan 9, 2024
@Nospamas
#183 Code review feedback
7841997 
- Removed unneeded triple quotes
- Refactored insert statement out
- Used pass more appropriately in migration
- Added newline at end of .gitignore
- Adjusted regex matches based on James' feedback and updated migration plan.
- Re-wrote migration test to batch test insert and full results to improve test performance.
Nospamas added a commit that referenced this issue Jan 9, 2024
@Nospamas
#183 black formatting
920ea2e
Nospamas added a commit that referenced this issue Jan 9, 2024
@Nospamas
#183 Adjust migration
cec1d17 
- Correct migration to run on customisable schema.
- Drop unaccent extension during down migration.
Nospamas added a commit that referenced this issue Jan 9, 2024
@Nospamas
Merge pull request #191 from pacificclimate/i-183-nev_var_name-check-…
975366c 
…constraint

#183 Add check constraint to meta_vars.net_var_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nospamas Nospamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nospamas @rod-glover