Add paths used by packagist updates to Dockerfile #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't add + change the path permissions here, when a Docker bind-mount is made, the path will be created and owned by root, thus failing future commands like mkdir, which is used by the packagist task under user www-data
|
Should we add a |
|
Definitely! I'm doing it right now. |
|
9543f02 adds the VOLUME instruction |
flavioheleno
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't add + change the path permissions here, when a
Docker bind-mount is made, the path will be created and owned
by root, thus failing future commands like mkdir, which is used
by the packagist task under user www-data
Not 100% pretty, but it works 😄