Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve container security #97

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Improve container security #97

merged 2 commits into from
Jul 26, 2022

Conversation

flavioheleno
Copy link
Member

This PR adds multiple recommendations from NGINXConfig

@flavioheleno
Copy link
Member Author

Current summary (without this PR): F

Source: SecurityHeaders

marcelo-lipienski
marcelo-lipienski reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@marcelo-lipienski marcelo-lipienski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although nginx config isn't my jam :)

okiedork
okiedork reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@okiedork okiedork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure on the PHP changes, but I guess you had a good reason to do them.

docker/nginx/default.conf Show resolved Hide resolved
docker/nginx/default.conf Outdated Show resolved Hide resolved
docker/nginx/default.conf Outdated Show resolved Hide resolved
docker/nginx/default.conf Outdated Show resolved Hide resolved
docker/nginx/default.conf Show resolved Hide resolved
docker/nginx/default.conf Show resolved Hide resolved
okiedork
okiedork approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@okiedork okiedork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nginx changes LGTM.
PHP changes: didn't review.

okiedork
okiedork reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@okiedork okiedork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the PHP Dockerfile.

I'll trust lines 186-194 for now :P

docker/php.Dockerfile Show resolved Hide resolved
docker/php.Dockerfile Show resolved Hide resolved
docker/php.Dockerfile Show resolved Hide resolved
docker/php.Dockerfile Show resolved Hide resolved
@okiedork
Copy link
Contributor

@flavioheleno ok to merge.

@flavioheleno flavioheleno merged commit a66c112 into develop Jul 26, 2022
@flavioheleno flavioheleno deleted the improv/docker-harden branch July 26, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelo-lipienski marcelo-lipienski marcelo-lipienski left review comments

@okiedork okiedork okiedork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flavioheleno @okiedork @marcelo-lipienski