Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License detection issue #20

Closed
roycyt opened this issue Jul 6, 2020 · 2 comments
Closed

License detection issue #20

roycyt opened this issue Jul 6, 2020 · 2 comments

Comments

@roycyt
Copy link

roycyt commented Jul 6, 2020 •
edited
Loading

Hi,
I just found that the license of this package is not correctly detected by pkg.go.dev and GitHub.
It would be great to follow the convention(?) to rename the mit.LICENSE file to LICENSE.

Ref: https://pkg.go.dev/license-policy
Ref: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license
@wagoodman
Copy link

This also causes havoc with automatic license audit tools, such as https://github.com/google/go-licenses . Moving the license to LICENSE would solve this.

@wagoodman wagoodman mentioned this issue Sep 18, 2020
Merged
shibumi added a commit to shibumi/packageurl-go that referenced this issue Dec 18, 2021
@shibumi
fix: issue package-url#20 license detection
b7c9d63
@shibumi shibumi mentioned this issue Dec 18, 2021
Merged
ashcrow pushed a commit that referenced this issue Feb 3, 2022
@shibumi @ashcrow
fix: issue #20 license detection
0ccaa12
@ashcrow
Copy link
Contributor

ashcrow commented Feb 3, 2022

In #28 LICENSE now exists and mit.LICENSE is now a symlink to LICENSE.

@ashcrow ashcrow closed this as completed Feb 3, 2022
petergardfjall pushed a commit to softsense/packageurl-go that referenced this issue Apr 12, 2022
@shibumi @petergardfjall
fix: issue package-url#20 license detection
85415a9
petergardfjall pushed a commit to softsense/packageurl-go that referenced this issue Apr 13, 2022
@shibumi @petergardfjall
fix: issue package-url#20 license detection
1b3cf3a
garethr added a commit to snyk/parlay that referenced this issue Jun 7, 2023
@garethr
Fix issue with 0.1.0 packageurl library license not being detected
49cb0c8 
Fixed upstreamin unreleased commit package-url/packageurl-go#20
another-rex pushed a commit to google/osv-scanner that referenced this issue Jun 21, 2023
@renovate-bot
fix(deps): update osv-scanner minor (#415)
ecc8b4a 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/package-url/packageurl-go](https://togithub.com/package-url/packageurl-go)
| require | patch | `v0.1.0` -> `v0.1.1` |
| [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require
| patch | `v2.25.6` -> `v2.25.7` |
| golang.org/x/tools | require | minor | `v0.9.3` -> `v0.10.0` |

---

### Release Notes

<details>
<summary>package-url/packageurl-go</summary>

###
[`v0.1.1`](https://togithub.com/package-url/packageurl-go/releases/tag/v0.1.1)

[Compare
Source](https://togithub.com/package-url/packageurl-go/compare/v0.1.0...v0.1.1)

### Changes

- [make PackageURL.String() use a value receiver rather than pointer
rec…](https://togithub.com/package-url/packageurl-go/commit/0789fa562603bb38a897134d735e7fc7ddf44b1e)
- [fix: update Go and CI /
tests](https://togithub.com/package-url/packageurl-go/commit/77b4cfeee1c804b53caebca3106b1fe7c2c20d9a)
- [fix: linting
issues](https://togithub.com/package-url/packageurl-go/commit/52157000a8d68a40397856d8c2128680cc11e1a9)
- [fix: empty slice declaration using
literal](https://togithub.com/package-url/packageurl-go/commit/7711a9e1356d3a2ee69f9b8a85d05a91ca0e544e)
- [fix: remove
travis.yml](https://togithub.com/package-url/packageurl-go/commit/36e2941dc9960a206504bb45e881717411d7adbd)
- [fix: implement missing Types: cran, conan,
swift](https://togithub.com/package-url/packageurl-go/commit/2101d64fcfee22dc344a0887a6793483c1cda33e)
- [docs: add badges for
README.md](https://togithub.com/package-url/packageurl-go/commit/f3dc3162680403e1cc638b6f60736c52f29c46a3)
- [fix: reformat code + doc
strings](https://togithub.com/package-url/packageurl-go/commit/3245c8ba61e712111c45b4d14b80ec58334311a0)
- [fix: spelling in
comments](https://togithub.com/package-url/packageurl-go/commit/07a9f5a63080dec6a80c69c484ad9667e70d0069)
- [fix: rename debian
type](https://togithub.com/package-url/packageurl-go/commit/5cd1dfb82b3add4880819caf25e5199bd43fc893)
- [feat: add cargo custom
type](https://togithub.com/package-url/packageurl-go/commit/fdd45fab1ae3d53240e6f8b7d5a62a42f6a30296)
- [feat: add missing package
urls](https://togithub.com/package-url/packageurl-go/commit/f395a911086ba1325189bc84fbe7aa9f500f1091)
- [fix:
issue](https://togithub.com/package-url/packageurl-go/commit/0ccaa1214f2b4e02f6b239b52fd1f4b1e553a297)
[package-url/packageurl-go#20
[license
detection](https://togithub.com/package-url/packageurl-go/commit/0ccaa1214f2b4e02f6b239b52fd1f4b1e553a297)
- [fix: add license
symlink](https://togithub.com/package-url/packageurl-go/commit/d70459300c8aa972fa61818f141a7b52ad0e5c9b)
- [Add in test-suite-json,
again](https://togithub.com/package-url/packageurl-go/commit/ab67608befffc606e03a3d23772deb3eb4fec71d)
- [Add in test-suite-json,
again](https://togithub.com/package-url/packageurl-go/commit/ab67608befffc606e03a3d23772deb3eb4fec71d)
- [Tests
fixed](https://togithub.com/package-url/packageurl-go/commit/32f04a9a10bf8781eb824460e070872b5afb5836)
- [Merge pull
request](https://togithub.com/package-url/packageurl-go/commit/89078438f1709503264de381344c07acebbbf901)
[package-url/packageurl-go#32
[from
DarthHater/TestSuiteData](https://togithub.com/package-url/packageurl-go/commit/89078438f1709503264de381344c07acebbbf901)
- [Copy the latest test data from master and stop downloading the test
d…](https://togithub.com/package-url/packageurl-go/commit/1f567e34d43b2727fe73403ef0cc246c866f5b85)
- [Fix huggingface version parsing. The version must be lowercase as
spe…](https://togithub.com/package-url/packageurl-go/commit/69d3c91e26332a2e67812d391ec0361e09f64b00)
- [Fix mlflow name adjustments. The case of the name depends on the
repo…](https://togithub.com/package-url/packageurl-go/commit/7e18e09ad38cc57b855a5234bd25c360a7cba0f2)
- [Fix composer name and namespace parsing. They must be lowercase, as
s…](https://togithub.com/package-url/packageurl-go/commit/2e2d03f9309372895124aa7a4220c190bbd0ae2b)
- [Merge pull
request](https://togithub.com/package-url/packageurl-go/commit/358f10025d4a923f7f9babc766f0968720e82240)
[package-url/packageurl-go#46
[from
Octogonapus/fix_tests](https://togithub.com/package-url/packageurl-go/commit/358f10025d4a923f7f9babc766f0968720e82240)

</details>

<details>
<summary>urfave/cli</summary>

### [`v2.25.7`](https://togithub.com/urfave/cli/releases/tag/v2.25.7)

[Compare
Source](https://togithub.com/urfave/cli/compare/v2.25.6...v2.25.7)

#### What's Changed

- Fix: fix v2 broken tests by
[@&#8203;dearchap](https://togithub.com/dearchap) in
[urfave/cli#1757
- Fix:(issue\_1755) Ensure that timestamp flag destination is set
correctly by [@&#8203;dearchap](https://togithub.com/dearchap) in
[urfave/cli#1756

**Full Changelog**:
urfave/cli@v2.25.6...v2.25.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on monday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/google/osv-scanner).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMjYuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashcrow @wagoodman @roycyt